feat: Make atexit flush registration optional For _HTTPBackgroundLogger#81
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intobraintrustdata:mainfrom Mar 18, 2026
Merged
Conversation
py/src/braintrust/logger.py
Outdated
| atexit.register(self._finalize) | ||
| disable_atexit_flush = False | ||
| try: | ||
| disable_atexit_flush = os.environ["BRAINTRUST_DISABLE_ATEXIT_FLUSH"] in ("True", "1") |
There was a problem hiding this comment.
We should move this up to match the other env variable logic that we have. We also don't seem to accept "True" for the other env
Contributor
Author
There was a problem hiding this comment.
I will change "True" -> "true", and will also adding "yes" as a option. because we are doing that already.
Mahhheshh (Mahhheshh)
force-pushed
the
fix/29
branch
from
5389ba3 to
73bda8a
Compare
Contributor
Author
|
Force pushed after rebasing |
Abhijeet Prasad (AbhiPrasad)
changed the title
Abhijeet Prasad (AbhiPrasad)
approved these changes
Mar 18, 2026
Abhijeet Prasad (AbhiPrasad)
merged commit 4fb512e
into
braintrustdata:main
33 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #29
BRAINTRUST_DISABLE_ATEXIT_FLUSHto disable the use ofatexit.register().Have a nice firday :)
